Re: [PATCH v1] Input: edt-ft5x06 - fix crash on EDT EP0110M09

From: Andy Shevchenko
Date: Thu Apr 09 2020 - 06:45:03 EST


On Thu, Apr 09, 2020 at 11:27:01AM +0200, Oliver Graute wrote:
> From: Oliver Graute <oliver.graute@xxxxxxxxxxxxxxxxx>
>
> remove edt_ft5x06_ts_readwrite() call because this result in a stack
> corruption crash on EP011M09

And how it's supposed now to work on the rest of variants?

> [ 2.968250] edt_ft5x06 1-0038: 1-0038 supply vcc not found, using dummy regulator
> [ 2.991327] input: EP0110M09 as /devices/platform/bus@5a000000/5a820000.i2c/i2c-1/1-0038/input/input0
> [ 3.011818] Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: edt_ft5x06_ts_probe+0x9e4/0xa98
> [ 3.022519] CPU: 0 PID: 5 Comm: kworker/0:0 Not tainted 5.6.0-rc1-next-20200214+ #69
> [ 3.030261] Hardware name: Advantech iMX8QM DMSSE20 (DT)
> [ 3.035583] Workqueue: events deferred_probe_work_func
> [ 3.040724] Call trace:
> [ 3.043179] dump_backtrace+0x0/0x1c0
> [ 3.046839] show_stack+0x14/0x20
> [ 3.050161] dump_stack+0xb4/0xfc
> [ 3.053477] panic+0x158/0x320
> [ 3.056531] print_tainted+0x0/0xa8
> [ 3.060015] edt_ft5x06_ts_probe+0x9e4/0xa98
> [ 3.064286] i2c_device_probe+0x2d0/0x2f8

No need to have below attached to the commit message. It's irrelevant.

> [ 3.068299] really_probe+0xd8/0x438
> [ 3.071874] driver_probe_device+0xdc/0x130
> [ 3.076064] __device_attach_driver+0x88/0x108

--
With Best Regards,
Andy Shevchenko