Re: [PATCH 12/12] MIPS: ip27: Fix includes

From: Mike Rapoport
Date: Thu Apr 09 2020 - 05:19:42 EST


On Wed, Apr 08, 2020 at 08:59:54PM +0800, Jiaxun Yang wrote:
> Somehow changes in topology messed up headers.
> So just add necessary headers to make it compile again.

Please avoid aftermath build fixes because it breaks bisection.
Each commit should be buildable, so this changes should go into the patches
that actually require them.

> Signed-off-by: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>
> ---
> arch/mips/include/asm/mach-ip27/mmzone.h | 2 ++
> arch/mips/include/asm/mach-ip27/topology.h | 2 ++
> arch/mips/include/asm/sn/addrs.h | 1 +
> 3 files changed, 5 insertions(+)
>
> diff --git a/arch/mips/include/asm/mach-ip27/mmzone.h b/arch/mips/include/asm/mach-ip27/mmzone.h
> index 08c36e50a860..e0a53b97b4a8 100644
> --- a/arch/mips/include/asm/mach-ip27/mmzone.h
> +++ b/arch/mips/include/asm/mach-ip27/mmzone.h
> @@ -2,6 +2,8 @@
> #ifndef _ASM_MACH_MMZONE_H
> #define _ASM_MACH_MMZONE_H
>
> +#include <linux/mmzone.h>
> +
> #include <asm/sn/addrs.h>
> #include <asm/sn/arch.h>
> #include <asm/sn/agent.h>
> diff --git a/arch/mips/include/asm/mach-ip27/topology.h b/arch/mips/include/asm/mach-ip27/topology.h
> index d66cc53feab8..601e350908f7 100644
> --- a/arch/mips/include/asm/mach-ip27/topology.h
> +++ b/arch/mips/include/asm/mach-ip27/topology.h
> @@ -2,6 +2,8 @@
> #ifndef _ASM_MACH_TOPOLOGY_H
> #define _ASM_MACH_TOPOLOGY_H 1
>
> +#include <linux/numa.h>
> +
> #include <asm/sn/types.h>
> #include <asm/mmzone.h>
>
> diff --git a/arch/mips/include/asm/sn/addrs.h b/arch/mips/include/asm/sn/addrs.h
> index 837d23e24976..1d3945ef2ca4 100644
> --- a/arch/mips/include/asm/sn/addrs.h
> +++ b/arch/mips/include/asm/sn/addrs.h
> @@ -13,6 +13,7 @@
> #ifndef __ASSEMBLY__
> #include <linux/smp.h>
> #include <linux/types.h>
> +#include <asm/io.h>
> #endif /* !__ASSEMBLY__ */
>
> #include <asm/addrspace.h>
> --
> 2.26.0.rc2
>
>

--
Sincerely yours,
Mike.