Re: [PATCH v5 2/9] media: adv748x: include everything adv748x.h needs into the file

From: Alex Riesen
Date: Fri Apr 03 2020 - 07:02:56 EST


Hi Kiran,

Kieran Bingham, Fri, Apr 03, 2020 12:48:06 +0200:
> On 02/04/2020 19:34, Alex Riesen wrote:
> > --- a/drivers/media/i2c/adv748x/adv748x-core.c
> > +++ b/drivers/media/i2c/adv748x/adv748x-core.c
> > @@ -10,6 +10,8 @@
> > * Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx>
> > */
> >
> > +#include "adv748x.h"
> > +
> > #include <linux/delay.h>
> > #include <linux/errno.h>
> > #include <linux/i2c.h>
>
> As linux/i2c.h is included in adv748x.h, we can remove this entry.
>

Corrected in v6.

Thanks for review!
Regards,
Alex