Re: [PATCH] powerpc/mm: ptdump: Add missing include <asm/vio.h>

From: Michael Ellerman
Date: Fri Apr 03 2020 - 00:58:58 EST


YueHaibing <yuehaibing@xxxxxxxxxx> writes:
> gcc build fails:

What config? Custom?

> arch/powerpc/mm/ptdump/hashpagetable.c: In function âpseries_findâ:
> arch/powerpc/mm/ptdump/hashpagetable.c:262:18: error: âH_SUCCESSâ undeclared (first use in this function); did you mean âFL_ACCESSâ?
> if (lpar_rc != H_SUCCESS)
> ^~~~~~~~~
> FL_ACCESS
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Fixes: 65e701b2d2a8 ("powerpc/ptdump: drop non vital #ifdefs")
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
> arch/powerpc/mm/ptdump/hashpagetable.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/mm/ptdump/hashpagetable.c b/arch/powerpc/mm/ptdump/hashpagetable.c
> index b6ed9578382f..8ea5f9a3b658 100644
> --- a/arch/powerpc/mm/ptdump/hashpagetable.c
> +++ b/arch/powerpc/mm/ptdump/hashpagetable.c
> @@ -20,6 +20,7 @@
> #include <asm/page.h>
> #include <asm/pgalloc.h>
> #include <asm/plpar_wrappers.h>
> +#include <asm/vio.h>

I don't think you want vio.h, hvcall.h has the definition of H_SUCCESS.

cheers