Re: [PATCH v2 1/2] blk-mq: In blk_mq_dispatch_rq_list() "no budget" is a reason to kick

From: Ming Lei
Date: Thu Apr 02 2020 - 21:55:39 EST


On Thu, Apr 02, 2020 at 08:51:29AM -0700, Douglas Anderson wrote:
> In blk_mq_dispatch_rq_list(), if blk_mq_sched_needs_restart() returns
> true and the driver returns BLK_STS_RESOURCE then we'll kick the
> queue. However, there's another case where we might need to kick it.
> If we were unable to get budget we can be in much the same state as
> when the driver returns BLK_STS_RESOURCE, so we should treat it the
> same.

The situation is really similar, especially the restart handler may
not see the request which may not be added to hctx->dispatch, so

Reviewed-by: Ming Lei <ming.lei@xxxxxxxxxx>


Thanks,
Ming