Re: [PATCH v1 2/5] clk: Introduce clk_round_rate_unboundly()

From: Dmitry Osipenko
Date: Thu Apr 02 2020 - 10:21:31 EST


02.04.2020 03:33, MichaÅ MirosÅaw ÐÐÑÐÑ:
> On Tue, Mar 31, 2020 at 02:16:14AM +0300, Dmitry Osipenko wrote:
> [...]
>> +/**
>> + * clk_round_rate_unboundly - unboundly round the given rate for a clk
>
> Just grammar nits:
>
> clk_round_rate_unbounded - round the given rate for a clk, ignoring users' min/max constraints
>
>> + * @clk: the clk for which we are rounding a rate
>> + * @rate: the rate which is to be rounded
>> + *
>> + * Takes in a rate as input and rounds it to a rate that the clk can use
>> + * which is then returned. The given rate isn't bounded by clk users min-max
>
> s/bounded/limited/ ?
>
>> + * rates, unlike in a case of clk_round_rate(). If clk doesn't support
>
> "... unlike in clk_round_rate()."
>
>> + * round_rate operation then the parent rate is returned.
>> + */
> [...]

Hello MichaÅ,

Thank you very much for the suggestion, I'll take it into account in the
next version.