Re: [PATCH] bcache: remove redundant variables i and n

[Coly Li]

On 2020/4/2 7:19 äå, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> Variables i and n are being assigned but are never used. They are
> redundant and can be removed.
> 

Hi Colin,

> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Thanks, I will submit this patch in Linux 5.7-rc series.

> ---
>  drivers/md/bcache/btree.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
> index 72856e5f23a3..114d0d73d909 100644
> --- a/drivers/md/bcache/btree.c
> +++ b/drivers/md/bcache/btree.c
> @@ -1907,10 +1907,8 @@ static int bch_btree_check_thread(void *arg)
>  	struct btree_iter iter;
>  	struct bkey *k, *p;
>  	int cur_idx, prev_idx, skip_nr;
> -	int i, n;
>  
>  	k = p = NULL;
> -	i = n = 0;
>  	cur_idx = prev_idx = 0;
>  	ret = 0;
>  
> 


-- 

Coly Li