Re: [PATCH v5 4/5] thermal: devfreq_cooling: Refactor code and switch to use Energy Model

From: Lukasz Luba
Date: Wed Apr 01 2020 - 06:50:02 EST




On 3/18/20 11:45 AM, Lukasz Luba wrote:
The overhauled Energy Model (EM) framework support also devfreq devices.
The unified API interface of the EM can be used in the thermal subsystem to
not duplicate code. The power table now is taken from EM structure and
there is no need to maintain calculation for it locally. In case when the
EM is not provided by the device a simple interface for cooling device is
used.

There is also an improvement in code related to enabling/disabling OPPs,
which prevents from race condition with devfreq governors.

[lkp: Reported the build warning]
Reported-by: kbuild test robot <lkp@xxxxxxxxx>
Reviewed-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx> # for tracing code
Signed-off-by: Lukasz Luba <lukasz.luba@xxxxxxx>
---
drivers/thermal/devfreq_cooling.c | 474 ++++++++++++++++--------------
include/linux/devfreq_cooling.h | 39 +--
include/trace/events/thermal.h | 19 +-
3 files changed, 277 insertions(+), 255 deletions(-)


Gentle ping.

Daniel or Amit could you have a look at this patch?

Regards,
Lukasz