Re: [PATCH] net: mdio: of: Do not treat fixed-link as PHY

From: Codrin.Ciubotariu
Date: Wed Apr 01 2020 - 03:51:05 EST


On 31.03.2020 15:59, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
>> Thanks guys. I thought there might be other controllers that have the
>> PHY nodes inside the ethernet node.
>
> Hi Codrin

Hi Andrew

>
> There are some still using this deprecated feature. But macb is the
> only one doing this odd looping over child nodes. It is this looping
> which is breaking things, not the use of the deprecated feature
> itself.

Yes, its due to the fact that the MDIO node is missing. Should we have
in mind to add an MDIO node under the macb node, where we could add the
PHY nodes? The macb bindings don't seem to require the PHY nodes
directly under the macb node, but the compatibility with the deprecated
feature needs to be maintained.

Best regards,
Codrin