Re: [PATCH 3/6] pci: add PCI quirk cmdmem fixup for Intel DSA device

From: Christoph Hellwig
Date: Wed Apr 01 2020 - 03:19:12 EST


On Mon, Mar 30, 2020 at 02:27:06PM -0700, Dave Jiang wrote:
> Since there is no standard way that defines a PCI device that receives
> descriptors or commands with synchronous write operations, add quirk to set
> cmdmem for the Intel accelerator device that supports it.

Why do we need a quirk for this? Even assuming a flag is needed in
struct pci_dev (and I don't really understand why that is needed to
start with), it could be set in ->probe.