Re: [PATCH linux hwmon-next v2 3/3] dt-bindings: (hwmon/sbtsi_tmep) Add SB-TSI hwmon driver bindings

From: Rob Herring
Date: Tue Mar 31 2020 - 15:29:37 EST


On Mon, Mar 23, 2020 at 04:33:54PM -0700, Kun Yi wrote:
> Document device tree bindings for AMD SB-TSI emulated temperature
> sensor.
>
> Signed-off-by: Kun Yi <kunyi@xxxxxxxxxx>
> Change-Id: Ife3285afa4cf8d410cb7bee1eb930dc0717084f9
> ---
> .../devicetree/bindings/hwmon/sbtsi_temp.txt | 14 ++++++++++++++

Convert to DT schema format and use the compatible string as the
filename.

> 1 file changed, 14 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/sbtsi_temp.txt
>
> diff --git a/Documentation/devicetree/bindings/hwmon/sbtsi_temp.txt b/Documentation/devicetree/bindings/hwmon/sbtsi_temp.txt
> new file mode 100644
> index 000000000000..4020f075699e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/sbtsi_temp.txt
> @@ -0,0 +1,14 @@
> +*AMD SoC SB-TSI hwmon driver.

Bindings are for hardware, not drivers.

Please give a better explanation of what this h/w.

> +
> +Required properties:
> +- compatible: manufacturer and chip name, should be
> + "amd,sbtsi",
> +
> +- reg: I2C bus address of the device
> +
> +Example:
> +
> +sbtsi@4c {
> + compatible = "amd,sbtsi";
> + reg = <0x4c>;
> +};
> --
> 2.25.1.696.g5e7596f4ac-goog
>