Re: [PATCH] gpio: Avoid using pin ranges with !PINCTRL

From: Geert Uytterhoeven
Date: Tue Mar 31 2020 - 09:05:57 EST


Hi Thierry,

Thanks for your patch!

On Mon, Mar 30, 2020 at 11:03 AM Thierry Reding
<thierry.reding@xxxxxxxxx> wrote:
> From: Thierry Reding <treding@xxxxxxxxxx>
>
> Do not use the struct gpio_device's .pin_ranges field if the PINCTRL
> Kconfig symbol is not selected to avoid build failures.
>
> Fixes: d2fbe53a806e ("gpio: Support GPIO controllers without pin-ranges")

WARNING: Unknown commit id 'd2fbe53a806e', maybe rebased or not pulled?

Fixes: 2ab73c6d8323fa1e ("gpio: Support GPIO controllers without pin-ranges")

> Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>

With the above fixed:
Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

This fixes the build (and boot) for rbtx4927, so:
Tested-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Gr{oetje,eeting}s,

Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds