Re: [PATCH] clk: qcom: msm8916: Fix the address location of pll->config_reg

From: Bryan O'Donoghue
Date: Tue Mar 31 2020 - 05:30:25 EST


On 30/03/2020 21:41, Bjorn Andersson wrote:
So while your change is correct, afaict it's a nop unless you fill out
the other fields as well.

Yes it shouldn't be a problem.

We cloned the 8196 driver and then started adding bits. In our case we need to start PLL3 and PLL4 from Linux, similar to line 3452 here

https://source.codeaurora.org/quic/la/kernel/msm-3.10/tree/drivers/clk/qcom/clock-gcc-8936.c?h=APSS.FSM.3.0

which does end up calling into the PLL recalc logic.

---
bod