Re: [PATCH 1/2] selftests: kvm: Add vm_get_fd() in kvm_util

From: Andrew Jones
Date: Tue Mar 31 2020 - 03:53:16 EST


On Mon, Mar 30, 2020 at 05:43:09PM -0300, Wainer dos Santos Moschetta wrote:
> Introduces the vm_get_fd() function in kvm_util which returns
> the VM file descriptor.
>
> Signed-off-by: Wainer dos Santos Moschetta <wainersm@xxxxxxxxxx>
> ---
> tools/testing/selftests/kvm/include/kvm_util.h | 1 +
> tools/testing/selftests/kvm/lib/kvm_util.c | 5 +++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/tools/testing/selftests/kvm/include/kvm_util.h b/tools/testing/selftests/kvm/include/kvm_util.h
> index ae0d14c2540a..aa4a70f969ed 100644
> --- a/tools/testing/selftests/kvm/include/kvm_util.h
> +++ b/tools/testing/selftests/kvm/include/kvm_util.h
> @@ -163,6 +163,7 @@ bool vm_is_unrestricted_guest(struct kvm_vm *vm);
> unsigned int vm_get_page_size(struct kvm_vm *vm);
> unsigned int vm_get_page_shift(struct kvm_vm *vm);
> unsigned int vm_get_max_gfn(struct kvm_vm *vm);
> +unsigned int vm_get_fd(struct kvm_vm *vm);
>
> struct kvm_userspace_memory_region *
> kvm_userspace_memory_region_find(struct kvm_vm *vm, uint64_t start,
> diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c
> index a6dd0401eb50..0961986c0d74 100644
> --- a/tools/testing/selftests/kvm/lib/kvm_util.c
> +++ b/tools/testing/selftests/kvm/lib/kvm_util.c
> @@ -1703,3 +1703,8 @@ unsigned int vm_get_max_gfn(struct kvm_vm *vm)
> {
> return vm->max_gfn;
> }
> +
> +unsigned int vm_get_fd(struct kvm_vm *vm)
> +{
> + return vm->fd;
> +}
> --
> 2.17.2
>

Please use an int instead of 'unsigned int' to match the fd type.

Thanks,
drew