Re: [PATCH v2 08/16] x86: replace arch macros from compiler with CONFIG_X86_{32,64}

From: Jason A. Donenfeld
Date: Tue Mar 31 2020 - 00:40:18 EST


On Mon, Mar 30, 2020 at 8:42 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
>
> Also, I slightly prefer
>
> #if defined(CONFIG_X86_32) && !defined(CONFIG_UML)
>
> to
>
> #if defined(__i386__) && !defined(__arch_um__)

I would much prefer that too.

At some point it'd be nice to see this whole mess cleaned up with UML.
I've seen this a few places -- UML thinks its x86, except where it's
not, and then there are problems. For example, a lot of SIMD related
code has this.

Jason