Re: [PATCH 02/39] MIPS: loongson64: Add header files path prefix

From: Jiaxun Yang
Date: Mon Mar 30 2020 - 23:34:59 EST




--
Jiaxun Yang

---- å ææä, 2020-03-30 18:00:19 maobibo <maobibo@xxxxxxxxxxx> æå ----
>
>
> On 03/30/2020 04:55 PM, Jiaxun Yang wrote:
> >
> >
> > ä 2020å3æ30æ GMT+08:00 äå4:38:51, bibo mao <maobibo@xxxxxxxxxxx> åå:
> >> Remove header files from arch/mips/include/asm/mach-loongson64
> >> to arch/mips/loongson64/include/mach
> >>
> >> Signed-off-by: bibo mao <maobibo@xxxxxxxxxxx>
> >
> > Hi Bibo,
> >
> > Thanks for your patch.
> >
> > What's your intention?
> > Did you meet any problem about headers?
> >
>
> Hi Jiaxun,
>
> When I add irqchip support for mips kvm, file virt/kvm/irqchip.c
> requires local header file arch/mips/kvm/irq.h, it fails to compile.
> Since there is file with the same name located at:
> arch/mips/include/asm/mach-generic/irq.h
> arch/mips/include/asm/mach-loongson64/irq.h
>
> The compiler fails to choose the correct header file irq.h,

You'd better rename kvm's irq.h in this case.

>
> regards
> bibo,mao
>
> >> ---
> >> arch/mips/Kconfig | 1 +
> >> arch/mips/loongson64/Platform | 2
> >> +-
> >> arch/mips/loongson64/env.c | 8
> >> ++++----