Re: [PATCH][next] net: ethernet: ti: fix spelling mistake "rundom" -> "random"

From: Joe Perches
Date: Mon Mar 30 2020 - 13:54:11 EST


On Mon, 2020-03-30 at 11:16 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> There is a spelling mistake in a dev_err error message. Fix it.
[]
> diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
[]
> @@ -1627,7 +1627,7 @@ static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common)
> port->slave.mac_addr) ||
> !is_valid_ether_addr(port->slave.mac_addr)) {
> random_ether_addr(port->slave.mac_addr);
> - dev_err(dev, "Use rundom MAC address\n");
> + dev_err(dev, "Use random MAC address\n");

This continues without returning an error value.
Is this actually an error?

It might be useful to describe the slave and
random ethernet address too.

Perhaps:

dev_notice(dev, "%pOF slave[%d] using random MAC address %pM\n",
port_np, port_id, port->slave.mac_addr);

or maybe dev_info