Re: [RFC PATCH v1 01/50] IB/qib: Delete struct qib_ivdev.qp_rnd

[Mark Rutland]

On Sun, Mar 29, 2020 at 04:08:25PM +0000, George Spelvin wrote:
> On Sun, Mar 29, 2020 at 11:17:10AM -0300, Jason Gunthorpe wrote:
> > You need to do a better job sending your patches, this is not
> > threaded, and not cc'd to linux-rdma, so it doesn't show in the
> > patchworks.
> 
> Indeed; mea culpa.  I forgot the magic option to git-format-patch.
> 
> Unfortunately, such things tend to get noticed only after the e-mail
> has been sent and one has embarrassed oneself publicly.  :-(
> 
> > In general, do not send such large series for things that are not
> > connected. Send small cleanups like this properly and directly so they
> > can be applied.
> 
> They're all concpetually connected, but yes.

Also, if you do send a series, *please* add a cover-letter explaining
what the overall purpose of the series is, and have all patches chained
in-reply-to that rather than patch 1. Otherwise reviewers have to
reverse-engineer the intent of the author.

You can generate the cover letter with:

$ git format-patch --cover $FROM..$TO

... and IIRC git send-email does the right thing by default if you hand
it all of the patches at once.

Thanks,
Mark.