Re: [PATCH] i2c: i2c-stm32f7: improve nack debug message

From: Pierre Yves MORDRET
Date: Mon Mar 30 2020 - 04:41:44 EST


Hello guys !

Reviewed-by: Pierre-Yves MORDRET <pierre-yves.mordret@xxxxxx>

Thanks

On 3/19/20 7:21 PM, Alain Volmat wrote:
> From: Fabrice Gasnier <fabrice.gasnier@xxxxxx>
>
> Add information on slave addr in the nack debug message.
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@xxxxxx>
> Signed-off-by: Alain Volmat <alain.volmat@xxxxxx>
> ---
> drivers/i2c/busses/i2c-stm32f7.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index 378956ac6d1d..78d40a4cc282 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -1431,7 +1431,8 @@ static irqreturn_t stm32f7_i2c_isr_event(int irq, void *data)
>
> /* NACK received */
> if (status & STM32F7_I2C_ISR_NACKF) {
> - dev_dbg(i2c_dev->dev, "<%s>: Receive NACK\n", __func__);
> + dev_dbg(i2c_dev->dev, "<%s>: Receive NACK (addr %x)\n",
> + __func__, f7_msg->addr);
> writel_relaxed(STM32F7_I2C_ICR_NACKCF, base + STM32F7_I2C_ICR);
> f7_msg->result = -ENXIO;
> }
>