Re: commit 23cb8490c0d3 ("MAINTAINERS: fix bad file pattern")

From: Andy Shevchenko
Date: Mon Mar 30 2020 - 03:35:16 EST


On Mon, Mar 30, 2020 at 5:38 AM Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> MAINTAINERS: fix bad file pattern
>
> Testing 'parse-maintainers' due to the previous commit shows a bad file
> pattern for the "TI VPE/CAL DRIVERS" entry in the MAINTAINERS file.
>
> There's also a lot of mis-ordered entries, but I'm still a bit nervous
> about the inevitable and annoying merge problems it would probably cause
> to fix them up.

I'm wondering if order depends to current locale. If so, the script
should override locale as well.

>
> The MAINTAINERS file is one of my least favorite files due to being huge
> and centralized, but fixing it is also horribly painful for that reason.
>
> The identical commit was sent at least twice.
> Once directly to you.
>
> https://patchwork.kernel.org/patch/11361131/
> https://lore.kernel.org/linux-media/20200128145828.74161-1-andriy.shevchenko@xxxxxxxxxxxxxxx/
>
>
> About the pain associated to fixing the file:
> I think it would be minimally painful to run
>
> $ ./scripts/parse-maintainers.pl --input=MAINTAINERS --output=MAINTAINERS --order
>
> Immediately before an -rc1 is released.
>
> Relatively few of any pending patches to MAINTAINERS
> in -next would be impacted and there would be better
> consistency in the silly file.
>
>


--
With Best Regards,
Andy Shevchenko