Re: [PATCH v5 1/2] dt-bindings: iio: accel: Add bmi088 accelerometer bindings

From: Jonathan Cameron
Date: Sat Mar 28 2020 - 12:04:38 EST


On Tue, 24 Mar 2020 09:03:07 +0100
Mike Looijmans <mike.looijmans@xxxxxxxx> wrote:

> This adds the device-tree bindings for the Bosch Sensortec BMI088 IMU,
> the accelerometer part.
>
> Signed-off-by: Mike Looijmans <mike.looijmans@xxxxxxxx>
Ah. For some reason I missed there was a v5. Comments on the v4 binding.

Jonathan

> ---
> v2: convert to yaml format
> v3..v4: -
> v5: submit together with driver code as patch series
> .../bindings/iio/accel/bosch,bmi088.yaml | 38 +++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml
> new file mode 100644
> index 000000000000..715f79c3b2a9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/accel/bosch,bma400.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Bosch BMI088 IMU accelerometer part
> +
> +maintainers:
> + - Mike Looijmans <mike.looijmans@xxxxxxxx>
> +
> +description: |
> + Acceleration part of the IMU sensor with an SPI interface
> +
> + Specifications about the sensor can be found at:
> + https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmi088-ds001.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - bosch,bmi088_accel
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +examples:
> + - |
> + spi {
> + bmi088_accel@1 {
> + compatible = "bosch,bmi088_accel";
> + reg = <1>;
> + spi-max-frequency = <10000000>;
> + };
> + };