Re:

From: Lee Duncan
Date: Fri Mar 27 2020 - 12:02:00 EST


On 3/27/20 2:20 AM, chenanqing@xxxxxxxx wrote:
> From: Chen Anqing <chenanqing@xxxxxxxx>
> To: Lee Duncan <lduncan@xxxxxxxx>
> Cc: Chris Leech <cleech@xxxxxxxxxx>,
> "James E . J . Bottomley" <jejb@xxxxxxxxxxxxx>,
> "Martin K . Petersen" <martin.petersen@xxxxxxxxxx>,
> ceph-devel@xxxxxxxxxxxxxxx,
> open-iscsi@xxxxxxxxxxxxxxxx,
> linux-scsi@xxxxxxxxxxxxxxx,
> linux-kernel@xxxxxxxxxxxxxxx,
> chenanqing@xxxxxxxx
> Subject: [PATCH] scsi: libiscsi: we should take compound page into account also
> Date: Fri, 27 Mar 2020 05:20:01 -0400
> Message-Id: <20200327092001.56879-1-chenanqing@xxxxxxxx>
> X-Mailer: git-send-email 2.18.2
>
> the patch is occur at a real crash,which slab is
> come from a compound page,so we need take the compound page
> into account also.
> fixed commit 08b11eaccfcf ("scsi: libiscsi: fall back to
> sendmsg for slab pages").
>
> Signed-off-by: Chen Anqing <chenanqing@xxxxxxxx>
> ---
> drivers/scsi/libiscsi_tcp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/libiscsi_tcp.c b/drivers/scsi/libiscsi_tcp.c
> index 6ef93c7af954..98304e5e1f6f 100644
> --- a/drivers/scsi/libiscsi_tcp.c
> +++ b/drivers/scsi/libiscsi_tcp.c
> @@ -128,7 +128,8 @@ static void iscsi_tcp_segment_map(struct iscsi_segment *segment, int recv)
> * coalescing neighboring slab objects into a single frag which
> * triggers one of hardened usercopy checks.
> */
> - if (!recv && page_count(sg_page(sg)) >= 1 && !PageSlab(sg_page(sg)))
> + if (!recv && page_count(sg_page(sg)) >= 1 &&
> + !PageSlab(compound_head(sg_page(sg))))
> return;
>
> if (recv) {
> --
> 2.18.2
>


This is missing a proper subject ...