RE: [PATCH] cifs: Remove locking in smb2_verify_signature() when calculating SMB2/SMB3 signature on receiving packets

From: AurÃlien Aptel
Date: Fri Mar 27 2020 - 07:05:27 EST


Long Li <longli@xxxxxxxxxxxxx> writes:
>>need for locks). AFAIK there's no state that need to be kept between
>>signing/encrypting calls beside the access to keys. Is it that expensive to
>>create/release?
>
> My guess is that crypto_alloc_shash() is a heavy call?

AFAIK there's no IO, just some memory allocation. Could be faster than
locking. Something to look into, maybe...

Cheers,
--
AurÃlien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 NÃrnberg, DE
GF: Felix ImendÃrffer, Mary Higgins, Sri Rasiah HRB 247165 (AG MÃnchen)