Re: [PATCH v3 1/4] dt-bindings: phy: renesas: usb2-phy: convert bindings to json-schema

From: Geert Uytterhoeven
Date: Fri Mar 27 2020 - 04:55:22 EST


Hi Shimoda-san,

On Fri, Mar 27, 2020 at 6:29 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> Convert Renesas R-Car generation 3 USB 2.0 PHY bindings documentation
> to json-schema.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>

Thanks for the update!

> --- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
> +++ /dev/null

> -The phandle's argument in the PHY specifier is the INT_STATUS bit of controller:
> -- 1 = USBH_INTA (OHCI)
> -- 2 = USBH_INTB (EHCI)
> -- 3 = UCOM_INT (OTG and BC)

Sorry, I failed to notice during my previous review that the above information
is lost during the conversion. I think it would be good to retain it in the
description for #phy-cells.

With that added:
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds