Re: [kbuild-all] Re: [RFC PATCH] usb: cdns3: cdns3_clear_register_bit() can be static

From: Greg Kroah-Hartman
Date: Fri Mar 27 2020 - 02:43:07 EST


On Fri, Mar 27, 2020 at 08:34:52AM +0800, Rong Chen wrote:
>
>
> On 3/26/20 9:04 PM, Greg Kroah-Hartman wrote:
> > On Thu, Mar 26, 2020 at 08:28:58PM +0800, kbuild test robot wrote:
> > > Fixes: 87db1192dc33 ("usb: cdns3: make signed 1 bit bitfields unsigned")
> > This original patch did not "cause" this problem, it's just that you for
> > some reason ran sparse for the first time on the file.
> >
> > So I can't take this as-is, can you remove this line and resend?
>
> Hi Greg,
>
> Sorry for the inconvenience, the patch was generated by the bot,
> we'll check and resend it.

It's fine that it was generated, it's a bug somewhere that thinks this
specific patch was a problem so that this generated patch fixed it.

Did you all just start running sparse on things again?

thanks,

greg k-h