Re: [PATCH net-next 03/12] ethtool: set coalescing parameters with COALESCE_SET request

From: Jakub Kicinski
Date: Fri Mar 27 2020 - 00:16:41 EST


On Fri, 27 Mar 2020 01:12:02 +0100 (CET) Michal Kubecek wrote:
> Implement COALESCE_SET netlink request to set coalescing parameters of
> a network device. These are traditionally set with ETHTOOL_SCOALESCE ioctl
> request. This commit adds only support for device coalescing parameters,
> not per queue coalescing parameters.
>
> Like the ioctl implementation, the generic ethtool code checks if only
> supported parameters are modified; if not, first offending attribute is
> reported using extack.
>
> Signed-off-by: Michal Kubecek <mkubecek@xxxxxxx>

Reviewed-by: Jakub Kicinski <kuba@xxxxxxxxxx>