Re: [PATCH] x86: fix early boot crash on gcc-10

From: Sergei Trofimovich
Date: Thu Mar 26 2020 - 17:54:32 EST


On Wed, 25 Mar 2020 14:31:37 +0100
Borislav Petkov <bp@xxxxxxxxx> wrote:

> On Tue, Mar 17, 2020 at 03:49:42PM +0100, Borislav Petkov wrote:
> > On Tue, Mar 17, 2020 at 03:39:14PM +0100, Jakub Jelinek wrote:
> > > That is because the option is called -fno-stack-protector, so one needs to
> > > use __attribute__((optimize("no-stack-protector")))
> >
> > Ha, that works even! :-)
> >
> > And my guest boots.
> >
> > I guess we can do that then. Looks like the optimal solution to me.
> >
> > Also, I'm assuming older gccs will simply ignore unknown optimize
> > options?
>
> Sergei,
>
> wanna send v2 where you add the function attribute to start_secondary()
> only instead?

Will attempt to write, test and send out the patch by tomorrow.

--

Sergei