Re: [PATCH v6 8/8] kvm: vmx: virtualize split lock detection

From: Thomas Gleixner
Date: Thu Mar 26 2020 - 10:56:09 EST


Xiaoyao Li <xiaoyao.li@xxxxxxxxx> writes:
> On 3/26/2020 7:10 PM, Thomas Gleixner wrote:
> If the host has it disabled, !split_lock_detect_on() is true, it skips
> following check due to ||
>
> if (!boot_cpu_has(X86_FEATURE_SPLIT_LOCK)) {
> inject #AC back to guest

That'd be a regular #AC, right?

> } else {
> if (guest_alignment_check_enabled() || guest_sld_on())
> inject #AC back to guest

Here is clearly an else path missing.

> }

Thanks,

tglx