Re: [PATCH v4 26/27] ata: move ata_eh_analyze_ncq_error() & co. to libata-sata.c
From: Christoph Hellwig
Date: Thu Mar 26 2020 - 06:00:49 EST
On Tue, Mar 17, 2020 at 03:43:32PM +0100, Bartlomiej Zolnierkiewicz wrote:
> * move ata_eh_analyze_ncq_error() and ata_eh_read_log_10h() to
> libata-sata.c
>
> * add static inline for ata_eh_analyze_ncq_error() for
> CONFIG_SATA_HOST=n case (link->sactive is non-zero only if
> NCQ commands are actually queued so empty function body is
> sufficient)
Looks good,
Reviewed-by: Christoph Hellwig <hch@xxxxxx>