Re: [PATCH v4 24/27] ata: move ata_sas_*() to libata-sata.c

From: Christoph Hellwig
Date: Thu Mar 26 2020 - 06:00:08 EST


On Tue, Mar 17, 2020 at 03:43:30PM +0100, Bartlomiej Zolnierkiewicz wrote:
> * un-inline:
> - ata_scsi_dump_cdb()
> - __ata_scsi_queuecmd()
>
> * un-static:
> - ata_scsi_sdev_config()
> - ata_scsi_dev_config()
> - ata_scsi_dump_cdb()
> - __ata_scsi_queuecmd()
>
> * move ata_sas_*() to libata-sata.c:
>
> * add static inlines for CONFIG_SATA_HOST=n case for
> ata_sas_{allocate,free}_tag()

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>