Re: [PATCH 2/4] fs: avoid double-writing the inode on a lazytime expiration

From: Christoph Hellwig
Date: Wed Mar 25 2020 - 11:01:14 EST


On Wed, Mar 25, 2020 at 01:28:23PM +0100, Christoph Hellwig wrote:
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -1448,6 +1448,11 @@ static struct dquot **ext4_get_dquots(struct inode *inode)
> return EXT4_I(inode)->i_dquot;
> }
>
> +static void ext4_lazytime_expired(struct inode *inode)
> +{
> + return ext4_dirty_inode(inode, I_DIRTY_SYNC);
> +}

FYI: this is inside an #ifdef CONFIG_QUOTA, so I'll have to respin even
if the overall approach looks good.