Re: [PATCH] net: PHY: bcm-unimac: Fix clock handling

From: Andrà Przywara
Date: Tue Mar 24 2020 - 12:27:17 EST


On 24/03/2020 16:17, Andrew Lunn wrote:

Hi,

> On Tue, Mar 24, 2020 at 04:10:10PM +0000, Andre Przywara wrote:
>> The DT binding for this PHY describes an *optional* clock property.
>> Due to a bug in the error handling logic, we are actually ignoring this
>> clock *all* of the time so far.
>>
>> Fix this by using devm_clk_get_optional() to handle this clock properly.
>>
>> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>
>
> Hi Andre
>
> Do you have a fixes: tag for this?

Should be:
Fixes: b78ac6ecd1b6b ("net: phy: mdio-bcm-unimac: Allow configuring MDIO
clock divider")

> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Thanks for that!

Cheers,
Andre