Re: [RESEND][PATCH v3 14/17] static_call: Add static_cond_call()

From: Linus Torvalds
Date: Tue Mar 24 2020 - 12:14:26 EST


On Tue, Mar 24, 2020 at 7:25 AM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> Extend the static_call infrastructure to optimize the following common
> pattern:
>
> if (func_ptr)
> func_ptr(args...)

Is there any reason why this shouldn't be the default static call pattern?

IOW, do we need the special "cond" versions at all? Couldn't we just
say that this is how static calls fundamentally work - if the function
is NULL, they are nops?

Linus