Re: [PATCH] i2c: nvidia-gpu: Handle timeout correctly in gpu_i2c_check_status()

From: Kai-Heng Feng
Date: Tue Mar 24 2020 - 07:12:21 EST


Hi Wolfram,

> On Mar 24, 2020, at 19:09, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
>
>
>> } while (time_is_after_jiffies(target));
>>
>> - if (time_is_before_jiffies(target)) {
>> + if (time_is_before_eq_jiffies(target)) {
>
> While unlikely, there is a tiny race between the time_is_* calls,
> jiffies could update inbetween them.
>
> So, for the sake of good programming practice, I'd recommend to set a
> flag in the do_while-loop and the have the logic above solely based on
> the flag.
>

Ok, I'll send a v2 based on your suggestion.

Kai-Heng