Re: [PATCH] usb: gadget: bcm63xx_udc:remove useless variable definition

From: Sergei Shtylyov
Date: Tue Mar 24 2020 - 04:35:48 EST


Hello!

On 24.03.2020 9:29, Tang Bin wrote:

In this function, the variable 'rc' is assigned after this place,
so the definition is invalid.

What definition? Did you mean assignment?

Signed-off-by: Tang Bin <tangbin@xxxxxxxxxxxxxxxxxxxx>
---
drivers/usb/gadget/udc/bcm63xx_udc.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/usb/gadget/udc/bcm63xx_udc.c b/drivers/usb/gadget/udc/bcm63xx_udc.c
index 54501814d..a7afa8c35 100644
--- a/drivers/usb/gadget/udc/bcm63xx_udc.c
+++ b/drivers/usb/gadget/udc/bcm63xx_udc.c
@@ -2321,8 +2321,6 @@ static int bcm63xx_udc_probe(struct platform_device *pdev)
if (rc)
return rc;
- rc = -ENXIO;
-
/* IRQ resource #0: control interrupt (VBUS, speed, etc.) */
irq = platform_get_irq(pdev, 0);
if (irq < 0)

MBR, Sergei