Re: [PATCH 1/2] kvm: selftests: Fix no directory error when OUTPUT specified

[Xiaoyao Li]

On 3/23/2020 11:40 PM, shuah wrote:
> On 3/15/20 3:34 AM, Xiaoyao Li wrote:
> > When build kvm selftests to an specified directory with
> >
> > ÂÂÂÂmake OUTPUT=~/kvm-selftests
> >
> > it encouters following errorï
>
> btw lib.mk can't handle relative paths yet. The problems
> you are seeing are related to that as well.

I tried with absolute path as well. It didn't work.

> This relative
> path issue should be fixed in lib.mk and not in individual
> tests.

OK. I'll try to fix it in lib.mk

> > /usr/bin/ld: cannot open output file
> > /home/lxy/kvm-selftests/x86_64/cr4_cpuid_sync_test: No such file or
> > directory
> > collect2: error: ld returned 1 exit status
> > make: *** [../lib.mk:141:
> > /home/lxy/kvm-selftests/x86_64/cr4_cpuid_sync_test] Error 1
> >
> > Signed-off-by: Xiaoyao Li <xiaoyao.li@xxxxxxxxx>
> > ---
> > Â tools/testing/selftests/kvm/Makefile | 1 +
> > Â 1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/testing/selftests/kvm/Makefile 
> > b/tools/testing/selftests/kvm/Makefile
> > index d91c53b726e6..86797e0242d4 100644
> > --- a/tools/testing/selftests/kvm/Makefile
> > +++ b/tools/testing/selftests/kvm/Makefile
> > @@ -66,6 +66,7 @@ LDFLAGS += -pthread $(no-pie-option) $(pgste-option)
> > Â # After inclusion, $(OUTPUT) is defined and
> > Â # $(TEST_GEN_PROGS) starts with $(OUTPUT)/
> > Â include ../lib.mk
> > +x := $(shell mkdir -p $(sort $(dir $(TEST_GEN_PROGS))))
>
> lib.mk would have created the directory.
>
> thanks,
> -- Shuah