Re: [PATCH 0/2] Bluetooth: Suspend related bugfixes

From: Abhishek Pandit-Subedi
Date: Mon Mar 23 2020 - 13:59:51 EST


Thanks Marcel.

On Mon, Mar 23, 2020 at 10:50 AM Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
>
> Hi Abhishek,
>
> > After further automated testing of the upstreamed suspend patches,
> > I found two issues:
> > - A failure in PM_SUSPEND_PREPARE wasn't calling PM_POST_SUSPEND.
> > I misread the docs and thought it would call it for all notifiers
> > already run but it only does so for the ones that returned
> > successfully from PM_SUSPEND_PREPARE.
> > - hci_conn_complete_evt wasn't completing on auto-connects (an else
> > block was removed during a refactor incorrectly)
> >
> > With the following patches, I've run a suspend stress test on a couple
> > of Chromebooks for several dozen iterations (each) successfully.
> >
> > Thanks
> > Abhishek
> >
> >
> >
> > Abhishek Pandit-Subedi (2):
> > Bluetooth: Restore running state if suspend fails
> > Bluetooth: Fix incorrect branch in connection complete
> >
> > net/bluetooth/hci_core.c | 39 ++++++++++++++++++++-------------------
> > net/bluetooth/hci_event.c | 17 +++++++++--------
> > 2 files changed, 29 insertions(+), 27 deletions(-)
>
> both patches have been applied to bluetooth-next tree.
>
> Regards
>
> Marcel
>