Re: [PATCH v1 0/2] Support built-in Mic on Tegra boards that use WM8903

From: Dmitry Osipenko
Date: Mon Mar 23 2020 - 12:05:29 EST


23.03.2020 18:59, Jon Hunter ÐÐÑÐÑ:
>
>
> On 20/03/2020 22:30, Stephen Warren wrote:
>> On 3/20/20 2:55 PM, Dmitry Osipenko wrote:
>>> Hello,
>>>
>>> This small series adds audio route for built-in microphone on NVIDIA Tegra
>>> boards that use WM8903 CODEC. In particular this is needed in order to unmute
>>> internal microphone on Acer A500 tablet device. I'm planning to send out the
>>> device tree for the A500 for 5.8, so will be nice to get the microphone
>>> sorted out. Please review and apply, thanks in advance.
>>
>> It's been a long time since I looked at this code, but the series looks
>> plausible,
>> Acked-by: Stephen Warren <swarren@xxxxxxxxxx>
>>
>> (I wonder why machine->gpio_int_mic_en was already parse but never used!)
>
> Looking at the ventana schematics, it appears that the internal-mic
> signals was connected to a header and not an actual mic, so maybe we
> never had a proper internal-mic on any board but allowed one to be
> connected.

I guess cardhu may have a mic, judging by downstream kernel sources (I
don't have cardhu schematics).

> Anyway, looks good to me as well.
>
> Acked-by: Jon Hunter <jonathanh@xxxxxxxxxx>

Thanks