Re: [PATCH] irqchip/versatile-fpga: Apply clear-mask earlier

[Marc Zyngier]

On 2020-03-22 11:45, Linus Walleij wrote:
> On Sat, Mar 21, 2020 at 2:40 PM Sungbo Eo <mans0n@xxxxxxxxxx> wrote:
>
> > Clear its own IRQs before the parent IRQ get enabled, so that the
> > remaining IRQs do not accidentally interrupt the parent IRQ 
> > controller.
> >
> > This patch also fixes a reboot bug on OX820 SoC, where the remaining
> > rps-timer IRQ raises a GIC interrupt that is left pending. After that,
> > the rps-timer IRQ is cleared during driver initialization, and there's
> > no IRQ left in rps-irq when local_irq_enable() is called, which evokes
> > an error message "unexpected IRQ trap".
> >
> > Fixes: bdd272cbb97a ("irqchip: versatile FPGA: support cascaded 
> > interrupts from DT")
> > Signed-off-by: Sungbo Eo <mans0n@xxxxxxxxxx>
> > Cc: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> > Cc: Daniel Golle <daniel@xxxxxxxxxxxxxx>
>
> Good catch!
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> Marc: Cc stable?

Sure, I'll add that.

Thanks,

        M.
--
Jazz is not dead. It just smells funny...