Re: [PATCH v11 3/8] iio: buffer-dmaengine: use %zu specifier for sprintf(align)

From: Jonathan Cameron
Date: Sat Mar 21 2020 - 13:22:24 EST


On Sat, 21 Mar 2020 10:53:10 +0200
Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx> wrote:

> The 'size_t' type behaves differently on 64-bit architectures, and causes
> compiler a warning of the sort "format '%u' expects argument of type
> 'unsigned int', but argument 3 has type 'size_t {aka long unsigned int}'".
>
> This change adds the correct specifier for the 'align' field.
>
> Fixes: 4538c18568099 ("iio: buffer-dmaengine: Report buffer length requirements")
> Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx>
Applied thanks.

Given lack of users of this infrastructure, I'm not that fussed
about marking this for stable or similar. However, I don't
mind someone requesting a backport if it is useful to them.

Jonathan

> ---
> drivers/iio/buffer/industrialio-buffer-dmaengine.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/buffer/industrialio-buffer-dmaengine.c b/drivers/iio/buffer/industrialio-buffer-dmaengine.c
> index b129693af0fd..94da3b1ca3a2 100644
> --- a/drivers/iio/buffer/industrialio-buffer-dmaengine.c
> +++ b/drivers/iio/buffer/industrialio-buffer-dmaengine.c
> @@ -134,7 +134,7 @@ static ssize_t iio_dmaengine_buffer_get_length_align(struct device *dev,
> struct dmaengine_buffer *dmaengine_buffer =
> iio_buffer_to_dmaengine_buffer(indio_dev->buffer);
>
> - return sprintf(buf, "%u\n", dmaengine_buffer->align);
> + return sprintf(buf, "%zu\n", dmaengine_buffer->align);
> }
>
> static IIO_DEVICE_ATTR(length_align_bytes, 0444,