Re: [PATCH] mm/compaction.c: Clean code by removing unnecessary assignment

[Vlastimil Babka]

On 3/18/20 6:45 PM, mateusznosek0@xxxxxxxxx wrote:
> From: Mateusz Nosek <mateusznosek0@xxxxxxxxx>
> 
> Previously 0 was assigned to variable 'last_migrated_pfn'. But the
> variable is not read after that, so the assignment can be removed.
> 
> Signed-off-by: Mateusz Nosek <mateusznosek0@xxxxxxxxx>

Acked-by: Vlastimil Babka <vbabka@xxxxxxx>

> ---
>  mm/compaction.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/compaction.c b/mm/compaction.c
> index 827d8a2b3164..4576d6c5afb5 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -2183,7 +2183,6 @@ compact_zone(struct compact_control *cc, struct capture_control *capc)
>  			ret = COMPACT_CONTENDED;
>  			putback_movable_pages(&cc->migratepages);
>  			cc->nr_migratepages = 0;
> -			last_migrated_pfn = 0;
>  			goto out;
>  		case ISOLATE_NONE:
>  			if (update_cached) {
>