Re: [PATCH v9 3/9] crypto: caam - drop global context pointer and init_done

From: Horia GeantÄ
Date: Fri Mar 20 2020 - 11:47:17 EST


On 3/19/2020 6:13 PM, Andrey Smirnov wrote:
> Leverage devres to get rid of code storing global context as well as
> init_done flag.
>
> Original code also has a circular deallocation dependency where
> unregister_algs() -> caam_rng_exit() -> caam_jr_free() chain would
> only happen if all of JRs were freed. Fix this by moving
> caam_rng_exit() outside of unregister_algs() and doing it specifically
> for JR that instantiated HWRNG.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>
> Cc: Chris Healy <cphealy@xxxxxxxxx>
> Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> Cc: Horia GeantÄ <horia.geanta@xxxxxxx>
> Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Cc: Iuliana Prodan <iuliana.prodan@xxxxxxx>
> Cc: linux-crypto@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: linux-imx@xxxxxxx
Reviewed-by: Horia GeantÄ <horia.geanta@xxxxxxx>

Thanks,
Horia