Re: [PATCH] arm/ftrace: Remove duplicate function

From: Steven Rostedt
Date: Fri Mar 20 2020 - 10:12:04 EST


On Fri, 20 Mar 2020 14:53:40 +0800
guoren@xxxxxxxxxx wrote:

> From: Guo Ren <guoren@xxxxxxxxxxxxxxxxx>
>
> There is no arch implementation of ftrace_arch_code_modify_prepare in arm,
> so just use the __weak one in kernel/trace/ftrace.c.

Reviewed-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>

-- Steve

>
> Signed-off-by: Guo Ren <guoren@xxxxxxxxxxxxxxxxx>
> ---
> arch/arm/kernel/ftrace.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/arm/kernel/ftrace.c b/arch/arm/kernel/ftrace.c
> index 10499d44964a..f66ade28eb8a 100644
> --- a/arch/arm/kernel/ftrace.c
> +++ b/arch/arm/kernel/ftrace.c
> @@ -56,11 +56,6 @@ static unsigned long adjust_address(struct dyn_ftrace *rec, unsigned long addr)
> return addr;
> }
>
> -int ftrace_arch_code_modify_prepare(void)
> -{
> - return 0;
> -}
> -
> int ftrace_arch_code_modify_post_process(void)
> {
> /* Make sure any TLB misses during machine stop are cleared. */