Re: [PATCH] Revert "x86/reboot, efi: Use EFI reboot for Acer TravelMate X514-51T"

From: Borislav Petkov
Date: Fri Mar 20 2020 - 09:54:33 EST


On Fri, Mar 20, 2020 at 08:37:54PM +0800, Daniel Drake wrote:
> Based on that I was considering that the patch could be reverted for
> cleanliness/ At the same time, I do not have strong feelings on this,
> no issues if the quirk is left in place.

Oh, I'd take the revert on cleanliness grounds any day of the week. But
if that broken fw has snuck out and someone comes and complains that it
wouldn't reboot properly, then I'd have to revert the revert.

And looking at that reboot_dmi_table[] of who's who of broken BIOSes,
one entry less ain't gonna make it prettier.

:-)

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette