Re: [PATCH v8 01/19] platform/x86: intel_scu_ipc: Split out SCU IPC functionality from the SCU driver

[Lee Jones]

On Tue, 03 Mar 2020, Mika Westerberg wrote:

> The SCU IPC functionality is usable outside of Intel MID devices. For
> example modern Intel CPUs include the same thing but now it is called
> PMC (Power Management Controller) instead of SCU. To make the IPC
> available for those split the driver into core part (intel_scu_ipc.c)
> and the SCU PCI driver part (intel_scu_pcidrv.c) which then calls the
> former before it goes and creates rest of the SCU devices. The SCU IPC
> will also register a new class that gets assigned to the device that is
> created under the parent PCI device.
> 
> We also split the Kconfig symbols so that INTEL_SCU_IPC enables the SCU
> IPC library and INTEL_SCU_PCI the SCU driver and convert the users
> accordingly. While there remove default y from the INTEL_SCU_PCI symbol
> as it is already selected by X86_INTEL_MID.
> 
> Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>  arch/x86/Kconfig                        |   2 +-
>  arch/x86/include/asm/intel_scu_ipc.h    |  18 +++

>  drivers/mfd/Kconfig                     |   4 +-

For my own reference:
  Acked-for-MFD-by: Lee Jones <lee.jones@xxxxxxxxxx>

>  drivers/platform/x86/Kconfig            |  24 ++--
>  drivers/platform/x86/Makefile           |   1 +
>  drivers/platform/x86/intel_scu_ipc.c    | 172 ++++++++++++++++--------
>  drivers/platform/x86/intel_scu_pcidrv.c |  55 ++++++++
>  7 files changed, 208 insertions(+), 68 deletions(-)
>  create mode 100644 drivers/platform/x86/intel_scu_pcidrv.c

-- 
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog