Re: [alsa-devel] [EXT] Re: [PATCH] ASoC: sgtl5000: Revert "ASoC: sgtl5000: Fix of unmute outputs on probe"

From: Marcel Ziswiler
Date: Fri Mar 20 2020 - 03:32:50 EST


Hi Tim

On Thu, 2020-03-19 at 13:49 -0700, Tim Harvey wrote:
> On Thu, Dec 12, 2019 at 4:24 AM Mark Brown <broonie@xxxxxxxxxx>
> wrote:
> > On Thu, Dec 12, 2019 at 10:46:31AM +0000, Alison Wang wrote:
> >
> > > We tested this standard solution using gstreamer and standard
> > > ALSA
> > > tools like aplay, arecord and all these tools unmute needed
> > > blocks
> > > successfully.
> > > [Alison Wang] I am using aplay. Do you mean I need to add some
> > > parameters for aplay or others to unmute the outputs?
> >
> > Use amixer.
>
> Marc / Oleksandr,
>
> I can't seem to find the original patch in my mailbox for 631bc8f:
> ('ASoC: sgtl5000: Fix of unmute outputs on probe')

I forwarded you that one again. OK?

> however I find it
> breaks sgtl5000 audio output on the Gateworks boards which is still
> broken on 5.6-rc6.

What exactly do you mean by "breaks"? Isn't it that you just need to
unmute stuff e.g. using amixer or using a proper updated asound.state
file with default states for your controls?

> Was there some follow-up patches that haven't made
> it into mainline yet regarding this?

I don't think so. It all works perfectly, not?

> The response above indicates maybe there was an additional ALSA
> control perhaps added as a resolution but I don't see any differences
> there.

Not that I am aware of, no.

> Best Regards,
>
> Tim

Cheers

Marcel