Re: [PATCH v2 1/2] hwmon: (pmbus) add support for 2nd Gen Renesas digital multiphase

From: Guenter Roeck
Date: Thu Mar 19 2020 - 23:02:46 EST


On Thu, Mar 19, 2020 at 10:49:50AM -0500, Grant Peltier wrote:
> Extend the isl68137 driver to provide support for 2nd generation Renesas
> digital multiphase voltage regulators.
>
> Signed-off-by: Grant Peltier <grantpeltier93@xxxxxxxxx>

I hate to (have to) say that, but there are lots of checkpatch errors and
warnings in this patch.

total: 7 errors, 4 warnings, 182 lines checked

That is really unnecessary. Please fix and resubmit.

Thanks,
Guenter