Re: [PATCH] KVM: x86: remove bogus user-triggerable WARN_ON

From: Sean Christopherson
Date: Thu Mar 19 2020 - 13:53:08 EST


On Thu, Mar 19, 2020 at 01:43:18PM -0400, Paolo Bonzini wrote:
> The WARN_ON is essentially comparing a user-provided value with 0. It is
> trivial to trigger it just by passing garbage to KVM_SET_CLOCK. Guests
> can break if you do so, but if it hurts when you do like this just do not
> do it.
>
> Reported-by: syzbot+00be5da1d75f1cc95f6b@xxxxxxxxxxxxxxxxxxxxxxxxx
> Fixes: 9446e6fce0ab ("KVM: x86: fix WARN_ON check of an unsigned less than zero")
> Cc: Sean Christopherson <sean.j.christopherson@xxxxxxxxx>
> Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> ---

Reviewed-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx>