Re: snd_hda_intel/sst-acpi sound breakage on suspend/resume since 5.6-rc1

From: Cezary Rojewski
Date: Thu Mar 19 2020 - 13:45:07 EST


On 2020-03-19 18:33, Cezary Rojewski wrote:

Thank you for being so cooperative during this 2day debug session.

The patch I mentioned earlier unintentionally (?) changed 'platform' component param for ssp0_port from 'dummy' to 'platform' for non-SOF solution:

diff --git a/sound/soc/intel/boards/broadwell.c b/sound/soc/intel/boards/broadwell.c
index b9c12e24c70b..db7e1e87156d 100644
--- a/sound/soc/intel/boards/broadwell.c
+++ b/sound/soc/intel/boards/broadwell.c
@@ -164,14 +164,6 @@ SND_SOC_DAILINK_DEF(platform,
ÂSND_SOC_DAILINK_DEF(codec,
ÂÂÂÂÂÂÂ DAILINK_COMP_ARRAY(COMP_CODEC("i2c-INT343A:00", "rt286-aif1")));

-#if IS_ENABLED(CONFIG_SND_SOC_SOF_BROADWELL)
-SND_SOC_DAILINK_DEF(ssp0_port,
-ÂÂÂÂÂÂÂÂÂÂ DAILINK_COMP_ARRAY(COMP_CPU("ssp0-port")));
-#else
-SND_SOC_DAILINK_DEF(ssp0_port,
-ÂÂÂÂÂÂÂÂÂÂ DAILINK_COMP_ARRAY(COMP_DUMMY()));
-#endif
-
Â/* broadwell digital audio interface glue - connects codec <--> CPU */
Âstatic struct snd_soc_dai_link broadwell_rt286_dais[] = {
ÂÂÂÂÂÂÂ /* Front End DAI links */
@@ -226,7 +218,7 @@ static struct snd_soc_dai_link broadwell_rt286_dais[] = {
ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ .ops = &broadwell_rt286_ops,
ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ .dpcm_playback = 1,
ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ .dpcm_capture = 1,
-ÂÂÂÂÂÂÂÂÂÂÂÂÂÂ SND_SOC_DAILINK_REG(ssp0_port, codec, platform),
+ÂÂÂÂÂÂÂÂÂÂÂÂÂÂ SND_SOC_DAILINK_REG(dummy, codec, dummy),
ÂÂÂÂÂÂÂ },


Of course I messed up the mail - above is a revert of said change.