Re: [PATCH 5.5 00/65] 5.5.11-rc1 review

From: Guenter Roeck
Date: Thu Mar 19 2020 - 10:44:40 EST


On 3/19/20 6:03 AM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.5.11 release.
> There are 65 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 21 Mar 2020 12:37:04 +0000.
> Anything received after that time might be too late.
>

arm:davinci_all_defconfig fails to build.

include/linux/gpio/driver.h: In function 'gpiochip_populate_parent_fwspec_twocell':
include/linux/gpio/driver.h:552:1: error: no return statement in function returning non-void [-Werror=return-type]
552 | }

The problem is caused by commit 8db6a5905e98 ("gpiolib: Add support for the
irqdomain which doesn't use irq_fwspec as arg") which is missing its fix,
commit 9c6722d85e922 ("gpio: Fix the no return statement warning"). That one
is missing a Fixes: tag, providing a good example why such tags are desirable.

Guenter